PEAK XOOPS - redundant id in XOOPS in englishin japanese

Archive | RSS |
XOOPS
XOOPS : redundant id in XOOPS
Poster : GIJOE on 2006-05-11 11:27:31 (10341 reads)

in englishin japanese
Redundant IDs are well used in XOOPS.

for example, newbb makes such URL.
viewtopic.php?topic_id=3656&forum=18&post_id=48548#forumpost48548

But, both forum(forum number=18) and topic_id(topic number=3656) are useless informations.
The only valid ID is post_id(post number=48548).

There are no topic number=3656 nor post number=48548 in forum number=18.
There are no post number=48548 in topic number=3656.

Such redundant ID makes bad effects like this:

- lost unique nature of the URL
Appending redundant (nonsense) query variables makes URL increase like arithmatic series.
This is serious problem against SEO.

- cause mistakes around privileges etc.
This is the true reason of newbb's bug.
http://www.peak.ne.jp/xoops/md/news/article.php?storyid=98


However, there are many modules create such redundant URLs.
Why?

I think the reason is for XOOPS core feature like notifications etc.

for examle, I light the module of mydownloads.
mydownloads also has redundant ID of cid in singlefile.php, though only lid is valid ID.

But, please let's see the notifications area in these links after loggin in.

lid=65
cid=4&lid=65

Both URL points the same file.
But options for notifications are different each other.

And the notification options for category are also displayed such URL.

cid=1&lid=65
The cid is obviously invalid.
But if someone register the category's notifications, he gets notifications about cid=1 instead of cid=4.

Though this can be said mistakes of planning of XOOPS, it is easy to solve it if you are one of the module developer.

Set proper redundant(category etc.) ID generated from the right ID into $_GET.
You can get the best result if cid is included or not in URL.


And you also have to remove redundant IDs from URLs.
This looks very important things.

Good luck!


Related articles
Printer friendly page Send this story to a friend

Comments list

GIJOE  Posted on 2006/5/19 17:49
This news is just a notification.
Not a security problem
gigamaster  Posted on 2006/5/17 8:39
So, this changes should be done into official modules code ? By removing all cid and keep only lid for contact, mymodules, mylinks, news, etc?
GIJOE  Posted on 2006/5/13 6:35 | Last modified
Quote:
irmtfan wrote:
dont think its can be possible in the latest versions of cbb
eg: cbb 3.0.4 RC2
Is this comment for http://www.peak.ne.jp/xoops/md/news/article.php?storyid=98&caldate=2006-5-10 ?

Anyway, I can say nothing about CBB because I don't read the codes at all.
irmtfan  Posted on 2006/5/11 14:17
dont think its can be possible in the latest versions of cbb
eg: cbb 3.0.4 RC2
Login
Username or e-mail:

Password:

Remember Me

Lost Password?

Register now!